Fix the custom requirements status
The requirement chip always appears as approved (green) following the
change If6e8e823: the function `_computeRequirementClass` expects a
boolean (status), but received the requirement object instead. We fix
this by passing in the "satisfied" boolean.
Invert the condition in tests, proving this fix is working.
Change-Id: I0f0a6f357f17c7f51ff9d70d0c3c0b490c784c91
diff --git a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements.js b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements.js
index e635d23..8ec00dd 100644
--- a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements.js
+++ b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements.js
@@ -65,7 +65,8 @@
if (change.requirements) {
for (const requirement of change.requirements) {
requirement.satisfied = requirement.status === 'OK';
- requirement.style = this._computeRequirementClass(requirement);
+ requirement.style =
+ this._computeRequirementClass(requirement.satisfied);
_requirements.push(requirement);
}
}
diff --git a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html
index 6ebdec3..3f35158 100644
--- a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html
+++ b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html
@@ -187,7 +187,7 @@
assert.ok(requirement.querySelector('.approved'));
});
- test('satisfied class is applied with NOT_READY', () => {
+ test('satisfied class is not applied with NOT_READY', () => {
element.change = {
status: 'NEW',
labels: {},
@@ -200,10 +200,10 @@
const requirement = element.$$('.requirement');
assert.ok(requirement);
- assert.ok(requirement.querySelector('.approved'));
+ assert.strictEqual(requirement.querySelector('.approved'), null);
});
- test('satisfied class is applied with RULE_ERROR', () => {
+ test('satisfied class is not applied with RULE_ERROR', () => {
element.change = {
status: 'NEW',
labels: {},
@@ -216,7 +216,7 @@
const requirement = element.$$('.requirement');
assert.ok(requirement);
- assert.ok(requirement.querySelector('.approved'));
+ assert.strictEqual(requirement.querySelector('.approved'), null);
});
});
</script>
