Google Git
Sign in
gerrit / gerrit / c7321a3448f681d934720da2d8955e319a4be4de
commitc7321a3448f681d934720da2d8955e319a4be4de[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Apr 28 13:29:54 2022 +0200
committerEdwin Kempin <ekempin@google.com>Thu Apr 28 13:29:54 2022 +0200
tree6140b7b737ca989165b8472322d9e72690ae7ca3
parentc4e0b21d294d01f7b805957691384b7a46c6c006 [diff]
PostReview: Set notify on BatchUpdate right after creating BatchUpdate

This improve readability as it makes it clear that the notify setting
applies to all BatchUpdateOps that are added to the BatchUpdate.

So far the code added multiple BatchUpdateOps, then set notify on the
BatchUpdate and then added more BatchUpdateOps. This looked like the
notify setting would only apply to the BatchUpdateOps that are added
after setting notify on the BatchUpdate, but in fact it applies to all
BatchUpdateOps. This is because the BatchUpdateOps are invoked only when
the BatchUpdate#execute method is invoked, which is after notify has
been set on the BatchUpdate. Avoid this confusion by setting notify on
BatchUpdate right after creating the BatchUpdate.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Release-Notes: skip
Change-Id: Iedb49f3a4a4fe29687ed745234b29d03996985e8
1 file changed
tree: 6140b7b737ca989165b8472322d9e72690ae7ca3
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.