Google Git
Sign in
gerrit / gerrit / 6266174d6ceb0d0eaea19e4c7307f635eecf03ed
commit6266174d6ceb0d0eaea19e4c7307f635eecf03ed[log] [tgz]
authorDave Borowitz <dborowitz@google.com>Wed Aug 15 15:28:51 2018 -0700
committerEdwin Kempin <ekempin@google.com>Thu Aug 16 08:44:28 2018 +0200
tree2ac039655ac14d04e5e8c8b77ccd17f99c4d9cca
parent212f4cc55422fe358da3d7b70f70e49df182de24 [diff]
Fix exception in rejectEmptyCommit check on root commit

Ied0c501a assumed that the commit always has one parent, which resulted
in ArrayIndexOutOfBoundsException. There happened to be no test coverage
for submitting a root commit with rejectEmptyCommit=true.

Fix this by skipping the empty-commit check on the root commit, even
when rejectEmptyCommit=true. This mirrors the fact that an empty commit
is created when createEmptyCommit=true even when rejectEmptyCommit=true,
and it provides a way to initialize the branch even if there should be
no real data there yet.

Change-Id: Ife12c2c472482d4602e85f5d350acc4a49d83c0d
3 files changed
tree: 2ac039655ac14d04e5e8c8b77ccd17f99c4d9cca
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-tests/
  6. gerrit-gwtdebug/
  7. gerrit-gwtui/
  8. gerrit-gwtui-common/
  9. gerrit-plugin-gwtui/
  10. java/
  11. javatests/
  12. lib/
  13. plugins/
  14. polygerrit-ui/
  15. prolog/
  16. prologtests/
  17. proto/
  18. resources/
  19. tools/
  20. webapp/
  21. .bazelproject
  22. .bazelrc
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .mailmap
  28. .pydevproject
  29. BUILD
  30. COPYING
  31. INSTALL
  32. README.md
  33. SUBMITTING_PATCHES
  34. version.bzl
  35. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.