commit | 60c5e251a1689345abab03a76fbef546232bfa6a | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Wed Oct 20 22:06:54 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Thu Oct 21 12:09:46 2021 +0200 |
tree | 84b47f94ccf92d8694f73573f8fc1ab794893f6d | |
parent | e8e11c51fcf23521e3e88f50413153f5ef838d58 [diff] |
Gate submit requirements with the experiment flag We gate submit requirements for all legacy/non-legacy requirements and open/merged changes with the existing enable_legacy_submit_requirements feature flag. Previously, submit requirement results were served by default by the change API (if any SRs are defined in project.config). The experiment flag meant: * For open changes: evaluate legacy submit records using SubmitRuleEvaluator, convert them to submit requirements and include them with the submit requirement results. * For merged changes: Load submit records from NoteDb and convert them to submit requirements. Serve them as submit requirements. The experiment also meant that, if both legacy and non-legacy non requirements were found with the same name, and if their statuses are matching, we return the non-legacy requirement (see Id5db11e3). If their statuses are not matching, we return both entries. In this change, we are redefining what the experiment is doing: If the experiment flag is off, no submit requirements are served by the backend. If it's on, we serve both legacy and non-legacy requirements. This is to allow a safer rollout and to prevent disrupting users once we start adding submit requirements to new gerrit installations. We are also interested in returning legacy submit requirements anyway and the UI can filter them out according to the needs. We also renamed the experiment. Change-Id: Ia3dc17da143df77045e77abcf8af79a982ad2cd7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.