| commit | 6074ab0a348fe6004cde4c9feb41c5586c64650d | [log] [tgz] |
|---|---|---|
| author | Matthias Sohn <matthias.sohn@sap.com> | Mon Feb 24 15:34:27 2020 +0100 |
| committer | Matthias Sohn <matthias.sohn@sap.com> | Mon Feb 24 16:55:12 2020 +0100 |
| tree | 982a14b1bc80abb9602afcdd7af8c805133efa99 | |
| parent | 281e7b6d8d89935bdcf22d01c84cb4cee683c8c0 [diff] |
Revert "JGitMetricModule: Replace anonymous Supplier instances with method references" This reverts commit 9ec9fee57fa30173ed7d457dfe1d1ec4f16a930f. This commit broke reporting JGit metrics. All metrics affected by this reported value 0. When debugging this problem it turned out the static method WindowCacheStats#getStats was evaluated too early when the JGitMetricModule#configure method was run. Instead it should be evaluated when the supplier's get method is called. Gerrit reconfigures the WindowCache using the configuration given in etc/gerrit.config. During this reconfiguration a new WindowCache instance and consequently also a new StatsRecorderImpl instance is created. Though the JGitMetricModule still had a reference to the old WindowCache's StatsRecorderImpl which never saw any metric data since the new WindowCache was using the new StatsRecorderImpl instance after the WindowCache reconfiguration. Change-Id: I9818eae94caccf330f914fd49e4d875b51cf18fd
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.