commit 6caf55596202dde286a8ff156f398efd1f367090
author Gal Paikin <paiking@google.com> Mon Jul 12 17:15:23 2021 +0200
committer Edwin Kempin <ekempin@google.com> Fri Jul 16 14:41:56 2021 +0200
tree 41836202572024adc2581dd6352237ec3d769bab
parent feddd042fd73002d6e393dcd47e00f777681aae1

Fix ListOfFilesDidNotChange

Due to faulty implementation, it was possible to do the following:
1. Add copyAllScoresiFlistOfFilesDidNoChange to a label.
2. Vote on that label on some change.
3. Add a new patch-set while modifying any file.

By doing so, the vote should not be sticky if modifying files that are
not related to this change. However, modifying any file was allowed and
the vote was still sticky. We fix this vulnerability by changing the
logic of the code.

While at it, we "cherry-picked" I9ce454278 and I33da589e. We forgot to
cherry-pick those, although this is quite a good idea to do so.
The reason it's a good idea is because it's possible to edit a file, get
it approved, and rename it and change it while replacing around 40% of
the content such that it is still considered a rename, but realistically
this is the same as creating a new file. That is a potential source
for security leaks.

Bug: Issue 14744
Change-Id: I6ebb5a5785219fccc67148af0d28c0cfdf49d10e
(cherry picked from commit da7a9a0b0bcc59797502ccfa2f82bcebf318be8d)