Upgrade gwtexpui to 1.3.3 to get LinkFindReplace
Use LinkFindReplaces for handling commentlink.*.link on the client
side, which is safer from XSS attacks in a future where commentlinks
are user-provided.
Because FindReplace is an interface, it can't be passed across the
JSON serialization barrier from server to client. Work around this for
now with an ugly hack, creating a JSON-serializable class within
GerritConfig (especially ugly because the conversion is not reversible
and it may need to be re-set on the client side). In the near future,
we will not use gwtjsonrpc to serialize these, and instead either get
them from the REST API on a per-project basis, or do rendering
server-side, so this hack is purely short-term.
Change-Id: I6a7a5bd9864ddde1872e2256732ea8437bcdc9f6
4 files changed
