Google Git
Sign in
gerrit / gerrit / 5fa829373e679118b380ea0902aefb775e8dfded
commit5fa829373e679118b380ea0902aefb775e8dfded[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Wed Sep 21 09:29:31 2022 +0200
committerBen Rohlfs <brohlfs@google.com>Wed Sep 21 09:50:20 2022 +0200
treeabb25e08c7f1a97d928e902c2b7647910f181f89
parentdaae0444fe781a8d585f8e0f5b521ef7282aa24c [diff]
Fix and clean up `setState` and `updateState` in `Model`

The router should actually be using `setState()` by default. Updating
the state partially may be the right thing to do in certain scenarios,
but at the moment we have a bug when navigating from a custom
dashboard to the default dashboard, because the state props are not
cleared. So let's fix this.

While we are here, let's make setting and updating state consistent in
the entire app. Add methods to the `Model` super class for `get`, `set`
and `update`. Use these methods everywhere and make `subject$` private.

Also, consistently `complete()` the `subject$` in `finalize()`.

Release-Notes: skip
Change-Id: I76f7f2d0db5a0165e8e65e9e01b8a811e2b18f56
17 files changed
tree: abb25e08c7f1a97d928e902c2b7647910f181f89
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.