| commit | 5dca444521d5669e71b246959ec51b4d21dc91b4 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Jul 24 13:17:58 2024 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Jul 26 10:45:10 2024 +0000 |
| tree | 460fc422017ebdb9cfa1ac267cece597d205641c | |
| parent | e199aa3eb8cc2495520b597c4888e8041d23eed3 [diff] |
Disallow tracing configs that trigger tracing for too many requests Misconfigured tracing configs or tracing configs that are too broad can trigger tracing for too many requests. This can badly impact the performance and the availability of the server, if tracing makes requests more expensive (e.g. if there are expensive logs that are only written when a request is traced). Examples for a misconfigured or trace configs that are too broad: * a tracing config that specifies neither of the match criteria (e.g. it contains an unsupported parameter, which can happen is the parameter has typo) * a tracing config that only specifies match criteria that are very broad (e.g. requestType=REST which would trigger tracing for all REST requests) Fix this by requiring that tracing configs specify at least one of requestUriPattern, account and projectPattern. Release-Notes: Disallowed tracing configs that trigger tracing for too many requests Bug: Google b/355393231 Change-Id: I9c9fac92f45e427087f7fe705169f73296c0b2c8 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.