commit 5d618ffe07caf7da4c5bd9584831f43cc7c56feb
author Alice Kober-Sotzek <aliceks@google.com> Wed Jul 31 18:41:30 2019 +0200
committer Alice Kober-Sotzek <aliceks@google.com> Thu Aug 01 13:47:29 2019 +0200
tree 1776988a06473da0b66c7b0c941ec42a20f372e2
parent e4ce4bcc05a878c97837abb2622ac1dd83d045a7

Log encounters of invalid enum values in REST requests

A specified string value for an enum which doesn't match any existing
enum value results in the enum field being simply ignored
(= unset) in the request. This also means that simple typos in the
name of an enum or the wrong case of it go unnoticed. We intend to
reject such kind of requests and force callers to adjust their input.
The base for this is already laid in this change. As a first step,
we intend to only log such encounters, though. A follow-up change will
change the behavior to rejections.

As it's highly desirable to not re-implement all of the logic to map
an enum to JSON and the other way around (and to also keep up with
new Gson features), this change introduces a delegate implementation
for enums which just does an additional check on top of the regular
implementation. Due to this and limitations of Gson, we can't log the
invalid enum value, though.

This change also introduces some tests which document the current
behavior. Those tests will also be helpful when we introduce the
rejections in the future.

Change-Id: I820fde9bca07038171da5d181518b9655d3a4dd2