5d182ddba9e23c161f8d32db7995c2697fd3b851 - gerrit

commit	5d182ddba9e23c161f8d32db7995c2697fd3b851	[log] [tgz]
author	Shawn Pearce <sop@google.com>	Tue Jul 23 14:23:55 2013 -0700
committer	Shawn Pearce <sop@google.com>	Tue Jul 23 14:24:05 2013 -0700
tree	1e3c3165fa1025b4e03a586a10ec887da97f1fad
parent	c541d31f1cbdac3801f17ef29e3b44f84425135c [diff]

Fix caching of /detail for modified reviewer lists

Rely only on ETag for change entity caching. The Last-Modified
value was derived from the lastUpdatedOn property, which is not
always modified when children are updated.

When adding or removing reviewers from a change perform a no-op
modification of the Change entity. This bumps its rowVersion as
a side-effect of the database mutation, causing the ETag to be
different on the next read.

Change-Id: If480f92b419041e7d62839ab12211058e78f828f

gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeResource.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/change/DeleteReviewer.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java[diff]

4 files changed