| commit | 5c9fd142161064f9e18ca07669ba8a5d626ad052 | [log] [tgz] |
|---|---|---|
| author | Shawn O. Pearce <sop@google.com> | Mon May 07 16:03:40 2012 -0700 |
| committer | Shawn O. Pearce <sop@google.com> | Mon May 07 16:03:40 2012 -0700 |
| tree | 54a8626998ec4ef5aeace2daec12afaa2c7f0381 | |
| parent | 1084cb299d11fad48fe89246b3f1c8511a4471a8 [diff] |
Flip order of _value testing recommended and disliked ChangeTable2 tests disliked, and then recommended. If both scores are supplied by two different users, favor the disliked negative score over the positive recommended score, matching ChangeTable2's own order and thus avoid a weird case of a red "1" value with no leading +/- value. Change-Id: Ic2ddac77ff57e4db2490ad6b7c8b6a16c1c90b43
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java index adacade..06c8e61 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
@@ -95,8 +95,8 @@ final native short _value() /*-{ if (this.value) return this.value; - if (this.recommended) return 1; if (this.disliked) return -1; + if (this.recommended) return 1; return 0; }-*/;