Google Git
Sign in
gerrit / gerrit / 5c6a5cd353dc0492fb123b2cfc79f6c8ff18c1c9
commit5c6a5cd353dc0492fb123b2cfc79f6c8ff18c1c9[log] [tgz]
authorKasper Nilsson <kaspern@google.com>Thu Jan 18 16:41:59 2018 -0800
committerKasper Nilsson <kaspern@google.com>Tue Jan 23 00:29:16 2018 +0000
treee7c5a8c37690ca33b0665b5be92fe3b4b82210b9
parent720dfa65636ebec848d14da5f420ccd2b1065f15 [diff]
Change `Cancel` to `Close` in gr-editor-view

Previously, tapping `Cancel` would discard any unsaved changes and
navigate directly to the edit patch set in the change view. This was
wrong for a couple of reasons:
- If the user came from a non-edit patch set and cancelled immediately,
  they would be taken to an unexpected patch set
- If the user started modifying a file and never saved, `Cancel` would
  navigate to a patch set that may not exist at all

This change restyles the buttons on the editor view to flat link
buttons, re-orders them, renames `Cancel` to `Close`, and modifies the
`Close` behavior to only navigate to the edit patch set if a file was
successfully modified.

Bug: Issue 4437
Change-Id: I130c417e8cda961f4d7cd9e384137f8bc2cba181
3 files changed
tree: e7c5a8c37690ca33b0665b5be92fe3b4b82210b9
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. resources/
  17. tools/
  18. webapp/
  19. .bazelproject
  20. .editorconfig
  21. .git-blame-ignore-revs
  22. .gitignore
  23. .gitmodules
  24. .mailmap
  25. .pydevproject
  26. BUILD
  27. COPYING
  28. INSTALL
  29. README.md
  30. SUBMITTING_PATCHES
  31. version.bzl
  32. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.