Google Git
Sign in
gerrit / gerrit / 5bfcea3e7bd7033e99645b967208fe3bdc4b01d4
commit5bfcea3e7bd7033e99645b967208fe3bdc4b01d4[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Wed May 15 10:05:07 2024 +0200
committerPaladox none <thomasmulhall410@yahoo.com>Wed May 15 11:30:30 2024 +0000
treea7a7a2d6875bd496358d45914191ca02019753c7
parentd6d4efd4308f921db27019fda8d7554a7f3f0446 [diff]
Fix issues with account details filling

Users have reported an issue with bogus account labels when the
account label was trying to fill in the details. One issue was that
the account (even the detailed one) does not have an `email` property
set. So the underlying `isDetailedAccount()` utility was producing
false return values and initiated the account to be looked up again
and again.

Another issue was that `Object.assign()` would actually modify the
cached object in place and thus potentially mess up the account object
for all subsequent callers.

Release-Notes: Fix bogus account labels.
Change-Id: Ib91fe57ad8026ef2a1daf61ddc2af5954ffd39ab
(cherry picked from commit ac98b4d387004032658eb0a3e9e4152d82e32a8c)
5 files changed
tree: a7a7a2d6875bd496358d45914191ca02019753c7
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. MODULE.bazel
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.