| commit | 5b8173715d419dc2ba60e613d20db888993f6593 | [log] [tgz] |
|---|---|---|
| author | Jonathan Nieder <jrn@google.com> | Thu Sep 29 12:49:34 2016 -0700 |
| committer | Jonathan Nieder <jrn@google.com> | Thu Sep 29 12:49:34 2016 -0700 |
| tree | 919b88928ed3410b82eed45de1546ae0d6af9563 | |
| parent | 56bcd7ad7b73237855d2d33a7448c7926ceb3c09 [diff] |
PostReview: Avoid NPE sanity-checking /COMMIT_MSG comments
We first check
if (Patch.isMagic(path)) { /* /COMMIT_MSG */
for (T comment : ent.getValue()) {
...
}
}
and only afterwards check whether ent.getValue() is null. This is
producing NullPointerException in production when ent.getValue() is
null.
It is not clear to me why we allow a null value here (what does it mean
to have a null comment list in a review?) but we allowed it before.
Move the null check so we can continue to allow it.
Regression introduced in c4ced8910f45d9bf7ad4d3044278dc6343c3d156 (Don't
compare commit message against auto-merge commit, 2016-09-12).
Change-Id: I8768283ab7be8ebb1d06dea432ec49d02354691e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.