Get rid of @override.
- Remove superfluous @override.
- Replace @override with override
- Get rid of empty overridden method in
`polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.ts`
Change-Id: Ibcf63c0d1d22e64abd36323f371549e56eee7e23
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-binary.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-binary.ts
index 1f89b28..4186a10 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-binary.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-binary.ts
@@ -40,6 +40,5 @@
return section;
}
- /** @override */
override updateRenderPrefs(_renderPrefs: RenderPreferences) {}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts
index 24b1341..67f5a58 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts
@@ -166,7 +166,6 @@
@property({type: Object})
_cancelableRenderPromise: CancelablePromise<unknown> | null = null;
- /** @override */
override disconnectedCallback() {
if (this._builder) {
this._builder.clear();
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
index 470e423..5629aa4 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.ts
@@ -216,7 +216,6 @@
section.appendChild(tr);
}
- /** @override */
override updateRenderPrefs(renderPrefs: RenderPreferences) {
const imageViewer = this._outputEl.querySelector(
'gr-image-viewer'
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
index 7700bce..057b926 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
@@ -137,6 +137,5 @@
return null;
}
- /** @override */
override updateRenderPrefs(_renderPrefs: RenderPreferences) {}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
index d4e36a2..b2dfa61 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
@@ -146,6 +146,5 @@
return null;
}
- /** @override */
override updateRenderPrefs(_renderPrefs: RenderPreferences) {}
}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts
index 9e45183..3e292fe 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts
@@ -93,7 +93,6 @@
);
}
- /** @override */
override disconnectedCallback() {
this.selectionChangeTask?.cancel();
super.disconnectedCallback();
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
index f16f5f3..06d31b3 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
@@ -303,16 +303,14 @@
);
}
- /** @override */
- ready() {
+ override ready() {
super.ready();
if (this._canReload()) {
this.reload();
}
}
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
this._getLoggedIn().then(loggedIn => {
this._loggedIn = loggedIn;
@@ -324,7 +322,6 @@
});
}
- /** @override */
override disconnectedCallback() {
this.disconnected$.next();
this.clear();
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
index 4eb33c7..a7702d1 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
@@ -48,8 +48,7 @@
private readonly restApiService = appContext.restApiService;
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
(
IronA11yAnnouncer as unknown as FixIronA11yAnnouncer
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts
index 63d42c2..b1e15a8 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts
@@ -117,13 +117,11 @@
private resetIsScrollingTask?: DelayedTask;
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
window.addEventListener('scroll', this.handleWindowScroll);
}
- /** @override */
override disconnectedCallback() {
this.resetIsScrollingTask?.cancel();
this.cancel();
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts b/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts
index 961ad45..0051b8b 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts
@@ -76,8 +76,7 @@
addListener(this, 'down', e => this._handleDown(e));
}
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
this.classList.add(SelectionClass.RIGHT);
}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
index fb2d6b3..61259d1 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
@@ -345,8 +345,7 @@
disconnected$ = new Subject();
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
this._throttledToggleFileReviewed = throttleWrap(e =>
this._handleToggleFileReviewed(e as CustomKeyboardEvent)
@@ -367,7 +366,6 @@
this.$.diffHost.addEventListener('render', this._onRenderHandler);
}
- /** @override */
override disconnectedCallback() {
this.disconnected$.next();
this.cursor.dispose();
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
index 1c40699..9fb2a19 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
@@ -318,14 +318,12 @@
this.addEventListener('moved-link-clicked', e => this._movedLinkClicked(e));
}
- /** @override */
- connectedCallback() {
+ override connectedCallback() {
super.connectedCallback();
this._observeNodes();
this.isAttached = true;
}
- /** @override */
override disconnectedCallback() {
this.isAttached = false;
this.renderDiffTableTask?.cancel();
