CmdLineParser: Make isBoolean(String) method private and improve its name Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I77fd653d5a138f7f07b6423670caa3dcce4a8d25
diff --git a/java/com/google/gerrit/util/cli/CmdLineParser.java b/java/com/google/gerrit/util/cli/CmdLineParser.java index 0fff861..be043fd 100644 --- a/java/com/google/gerrit/util/cli/CmdLineParser.java +++ b/java/com/google/gerrit/util/cli/CmdLineParser.java
@@ -330,7 +330,7 @@ String name = makeOption(key); if (isKnownOption(name)) { - if (isBoolean(name)) { + if (isBooleanOption(name)) { boolean on = false; for (String value : params.get(key)) { on = toBoolean(key, value); @@ -353,10 +353,6 @@ parser.parseArgument(knownArgs.toArray(new String[knownArgs.size()])); } - public boolean isBoolean(String name) { - return findHandler(makeOption(name)) instanceof BooleanOptionHandler; - } - public void parseWithPrefix(String prefix, Object bean) { parser.parseWithPrefix(prefix, bean); } @@ -365,6 +361,10 @@ parser.addOptionsWithMetRequirements(); } + private boolean isBooleanOption(String name) { + return findHandler(makeOption(name)) instanceof BooleanOptionHandler; + } + private String makeOption(String name) { if (!name.startsWith("-")) { if (name.length() == 1) {