commit | c7ba2ccd6f8d6a061e75c09b6eb180843aece872 | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Thu Dec 13 10:44:38 2018 +0100 |
committer | Patrick Hiesel <hiesel@google.com> | Fri Dec 14 08:57:33 2018 +0100 |
tree | 45deeec72a9e98e4459d3824fceee4118329f20f | |
parent | f6ea2da616113956c3daf4d1e6551e977b97d85c [diff] |
Return tags on full ref evaluation for users that have READ on refs/* We are working on removing the shortcut that prevents Gerrit from performing a full ref filtering if users have READ on refs/*. Gerrit's ACLs are based on refs, not on tags. Tags are being returned if they are reachable by any of the visible refs. That poses the problem of what we do with orphaned tags. Due to the shortcut, users were able to see orphaned tags in the past. In general it seems like a sane assumption to make that when one has READ on refs/* they can see all the tags as well. This is what this commit implements. We considered adding a new ACL namespace (refs/tags/*) but that would add another layer of complexity to an already hard to understand ACL system. On top, it would make it easy for users to make code accessible by adding a tag to a commit on a hidden ref when the administrator granted READ on refs/tags/* to a broader audience. Change-Id: I8d9f6a54228ed5650ded6a285c1afbf9525511e6
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.