| commit | 596ee7838f7a36a6f2d25221690ec7bdf8b6a799 | [log] [tgz] |
|---|---|---|
| author | Paladox none <thomasmulhall410@yahoo.com> | Sun Nov 24 16:45:18 2019 +0000 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Sun Nov 24 23:21:38 2019 +0000 |
| tree | ded22e5780501e32bce95d12d6456cdea383eb71 | |
| parent | b16d0a720ceba81ba4fe2e91d9eb33d5b772eee2 [diff] |
Change on-tap to on-click for iron-dropdown This fixes an issue under iOS 13 when clicking a button in the dropdown would not work. Bug: Issue 11984 Change-Id: I339524e1c9cde49f74c2b5228ca35ec9c0dfdece (cherry picked from commit ed757c0e7ae001c346519024435c8ec252d2de25)
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.html b/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.html index f4b120a..42b6f94 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.html +++ b/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.html
@@ -147,7 +147,7 @@ id="dropdown" vertical-align="top" allow-outside-scroll="true" - on-tap="_handleDropdownTap"> + on-click="_handleDropdownClick"> <paper-listbox class="dropdown-content" slot="dropdown-content"
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js b/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js index 40d8811..c8f4f63 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js +++ b/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js
@@ -75,7 +75,7 @@ * Handle a click on the iron-dropdown element. * @param {!Event} e */ - _handleDropdownTap(e) { + _handleDropdownClick(e) { // async is needed so that that the click event is fired before the // dropdown closes (This was a bug for touch devices). this.async(() => {
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.html b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.html index 47ab03a..373e77d 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.html +++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.html
@@ -109,7 +109,7 @@ vertical-offset="[[verticalOffset]]" allow-outside-scroll="true" horizontal-align="[[horizontalAlign]]" - on-tap="_handleDropdownTap"> + on-click="_handleDropdownClick"> <div class="dropdown-content" slot="dropdown-content"> <ul> <template is="dom-if" if="[[topContent]]">
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js index 974f179..c06ffc9 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js +++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
@@ -152,7 +152,7 @@ * Handle a click on the iron-dropdown element. * @param {!Event} e */ - _handleDropdownTap(e) { + _handleDropdownClick(e) { this._close(); },