| commit | 594a4632e33b73d8510a2e0723be7d528650660b | [log] [tgz] |
|---|---|---|
| author | Eryk Szymanski <eryksz@gmail.com> | Wed May 16 12:12:07 2018 +0200 |
| committer | David Pursehouse <dpursehouse@collab.net> | Wed May 16 19:42:03 2018 +0900 |
| tree | 107ad07388e2250c59430c2929af3f87f22dd062 | |
| parent | 0d9927c858e405f20543f575d50b6e3e17d9f95b [diff] |
DropWizardMetricMaker: Improve error message when metric name is invalid In case the metric name is invalid, the stack trace only contains the required pattern but not the name itself. Add the metric name to the message so that the stack trace is more informative. Change-Id: If1750a46e7d1e513d3d372212b8a95c89f682da0 Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
diff --git a/gerrit-server/src/main/java/com/google/gerrit/metrics/dropwizard/DropWizardMetricMaker.java b/gerrit-server/src/main/java/com/google/gerrit/metrics/dropwizard/DropWizardMetricMaker.java index 118ca03..1e075aa 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/metrics/dropwizard/DropWizardMetricMaker.java +++ b/gerrit-server/src/main/java/com/google/gerrit/metrics/dropwizard/DropWizardMetricMaker.java
@@ -339,7 +339,8 @@ private static void checkMetricName(String name) { checkArgument( METRIC_NAME_PATTERN.matcher(name).matches(), - "metric name must match %s", + "invalid metric name '%s': must match pattern '%s'", + name, METRIC_NAME_PATTERN.pattern()); }