commit | 75d6058f4e6278af609cc89829a834906c80db6d | [log] [tgz] |
---|---|---|
author | Ole Rehmsen <oler@google.com> | Tue Nov 13 09:26:35 2018 +0100 |
committer | Ole Rehmsen <oler@google.com> | Tue Nov 13 09:55:37 2018 +0100 |
tree | b47bf394bfff4314a1c3110578b2c92175945819 | |
parent | 8a460d17a067f6a7250ae23180a1965c99883547 [diff] |
Fix handling comment save in Shadow DOM e.target in native Shadow DOM will be retargetted to be some containing element, not the gr-diff-comment element as expected and as it would be in shady DOM. I originally wanted to fix this by using Polymer.dom(e).rootTarget but that has two downsides: 1) It's harder to test, because Polymer.dom does a instanceof check, and creating and actual Event in the test means we cannot easily set target because that is readonly. 2) It makes this component more dependent on gr-diff-comment having a public property comment. Luckily there is no reason to muck with e.target in the first place because these event actually have the comment set on the detail aswell, so just reading it from there circumvents the problem and is easy to test. Bug: Issue 10016 Change-Id: I08a546da4ba8d054ff4738f08d1f86ca6e510a3c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.