| commit | 586d0cf011edecb42d529cd65c629e8470eea667 | [log] [tgz] |
|---|---|---|
| author | Saša Živkov <sasa.zivkov@sap.com> | Thu Mar 10 17:40:50 2016 +0100 |
| committer | David Pursehouse <dpursehouse@collab.net> | Fri Jun 24 10:49:25 2016 +0900 |
| tree | 9d521cc59645feb46dcd79e92208fc5f0d6cd72c | |
| parent | 4306a0921df9451839305b8db29be2b662d43f34 [diff] |
Instead of deleting patch-set-approval set vote to zero Problem: some reviewers get removed from change after it gets submitted. On submitting a change we used to delete those patch-set-approvals where the reviewer didn't have permission to vote in that label or the label didn't exist any more. On the other side, when a reviewer is added to a change this is recorded as patch-set-approval on some label, with zero vote. If the chosen label happens to be one where the reviewer doesn't have permission to vote, this patch-set-approval will be deleted on submit and the reviewer will be removed from the change. Even if the added reviewer did have permission to vote in the chosen label, the label could get deleted before the change is submitted. Again, the reviewer will be removed from the change. Instead of deleting patch-set-approvals set the vote to zero so that we don't accidentally remove reviewers. NOTE: this issue doesn't occur when using NoteDb. In NoteDb we keep track of reviewers explicitly and this is why for NoteDb we still want to delete these approvals. Bug: Issue 4163 Change-Id: I4d4f8d7b55c12a0484257192e7d0ed8d2f71ebcc
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.