commit 58267b727f3e71fc5cb5790b25b7b56ae9f9ba5a
author Ben Rohlfs <brohlfs@google.com> Fri May 27 15:59:18 2022 +0200
committer Ben Rohlfs <brohlfs@google.com> Tue May 31 10:24:35 2022 +0200
tree 2992608a4f0377f1ccb5b6f84ab9f7e45efc5027
parent 507c6bd393d721cb917821c993dc6a4025923d06

Refactoring: Replace `ParentPatchSetNum` with `PARENT`

Also replace instances of the string 'PARENT' with the constant
`PARENT`.

Release-Notes: skip
Change-Id: I694c6c621160d34badd7179a8b115fbca88809d5

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts

diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
index 6ad8f1f..4cfec21 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
@@ -61,7 +61,7 @@
   CommitId,
   EditPatchSetNum,
   NumericChangeId,
-  ParentPatchSetNum,
+  PARENT,
   PatchRange,
   RelatedChangeAndCommitInfo,
   ReviewInputTag,
@@ -368,7 +368,7 @@
   test('_handleMessageAnchorTap', () => {
     element._changeNum = 1 as NumericChangeId;
     element._patchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
       patchNum: 1 as RevisionPatchSetNum,
     };
     element._change = createChangeViewChange();
@@ -814,7 +814,7 @@
     setup(() => {
       element._changeNum = TEST_NUMERIC_CHANGE_ID;
       element._patchRange = {
-        basePatchNum: ParentPatchSetNum,
+        basePatchNum: PARENT,
         patchNum: 1 as RevisionPatchSetNum,
       };
       element._change = {
@@ -1211,7 +1211,7 @@
     };
     element._changeNum = TEST_NUMERIC_CHANGE_ID;
     element._patchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
       patchNum: 1 as RevisionPatchSetNum,
     };
     const change = {
@@ -1272,7 +1272,7 @@
     } as ParsedChangeInfo;
     element._changeNum = undefined;
     element._patchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
       patchNum: 2 as RevisionPatchSetNum,
     };
     element._change = change;
@@ -1578,9 +1578,9 @@
       },
     };
     const _patchRange: ChangeViewPatchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
     };
-    assert.equal(element._getBasePatchNum(_change, _patchRange), 'PARENT');
+    assert.equal(element._getBasePatchNum(_change, _patchRange), PARENT);
 
     element._prefs = {
       ...createPreferences(),
@@ -1611,7 +1611,7 @@
     assert.equal(element._getBasePatchNum(_change2, _patchRange), -1);
 
     _patchRange.patchNum = 1 as RevisionPatchSetNum;
-    assert.equal(element._getBasePatchNum(_change2, _patchRange), 'PARENT');
+    assert.equal(element._getBasePatchNum(_change2, _patchRange), PARENT);
   });
 
   test('_openReplyDialog called with `ANY` when coming from tap event', async () => {
@@ -1686,7 +1686,7 @@
       .callsFake(() => Promise.resolve());
 
     element._patchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
       patchNum: 2 as RevisionPatchSetNum,
     };
     element._change = {
@@ -1804,13 +1804,13 @@
       );
     assert.isTrue(
       callCompute(
-        {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum},
+        {basePatchNum: PARENT, patchNum: 1 as RevisionPatchSetNum},
         {...createAppElementChangeViewParams(), edit: true}
       )
     );
     assert.isFalse(
       callCompute(
-        {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum},
+        {basePatchNum: PARENT, patchNum: 1 as RevisionPatchSetNum},
         createAppElementChangeViewParams()
       )
     );
@@ -1859,7 +1859,7 @@
 
   test('file-action-tap handling', async () => {
     element._patchRange = {
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
       patchNum: 1 as RevisionPatchSetNum,
     };
     element._change = {
@@ -2024,13 +2024,13 @@
     assert.isFalse(element.hasPatchRangeChanged(params));
     assert.isFalse(element.hasPatchNumChanged(params));
 
-    params.basePatchNum = ParentPatchSetNum;
+    params.basePatchNum = PARENT;
     // undefined means navigate to latest patchset
     params.patchNum = undefined;
 
     element._patchRange = {
       patchNum: 2 as RevisionPatchSetNum,
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
     };
 
     assert.isTrue(element.hasPatchRangeChanged(params));
@@ -2038,7 +2038,7 @@
 
     element._patchRange = {
       patchNum: 4 as RevisionPatchSetNum,
-      basePatchNum: ParentPatchSetNum,
+      basePatchNum: PARENT,
     };
 
     assert.isFalse(element.hasPatchRangeChanged(params));
@@ -2209,7 +2209,7 @@
   suite('gr-reporting tests', () => {
     setup(() => {
       element._patchRange = {
-        basePatchNum: ParentPatchSetNum,
+        basePatchNum: PARENT,
         patchNum: 1 as RevisionPatchSetNum,
       };
       sinon