commit 578bab17754f8c811f77eb569438aba1f855cd8d
author Shawn O. Pearce <sop@google.com> Fri Apr 23 20:41:31 2010 -0700
committer Shawn O. Pearce <sop@google.com> Fri Apr 23 20:41:31 2010 -0700
tree 50ec6cc0b02b226476c24446a87ef13bfff5dfd9
parent ea154229511f69f1213364c378893947b8a53787

Don't show remove reviewer button on closed changes

If the change is closed, we shouldn't be able to delete a reviewer
from the reviewer table.  So don't display the button to the user.

Change-Id: I1b4c7e3f2f764a7109fba3bbd93cef9ce4d2622e
Signed-off-by: Shawn O. Pearce <sop@google.com>

gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
index 9502566..d6cc2f3 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
@@ -154,7 +154,7 @@
     } else {
       table.setVisible(true);
       for (int i = 0; i < rows.size(); i++) {
-        displayRow(i + 1, rows.get(i));
+        displayRow(i + 1, rows.get(i), change);
       }
     }
 
@@ -235,7 +235,8 @@
         });
   }
 
-  private void displayRow(final int row, final ApprovalDetail ad) {
+  private void displayRow(final int row, final ApprovalDetail ad,
+      final Change change) {
     final CellFormatter fmt = table.getCellFormatter();
     final Map<ApprovalCategory.Id, PatchSetApproval> am = ad.getApprovalMap();
     final StringBuilder hint = new StringBuilder();
@@ -284,7 +285,7 @@
     //
     // Remove button
     //
-    if (Gerrit.isSignedIn()) {
+    if (change.getStatus().isOpen() && Gerrit.isSignedIn()) {
       Button removeButton = new Button("X");
       removeButton.setStyleName(Gerrit.RESOURCES.css().removeReviewer());
       removeButton.addClickHandler(new ClickHandler() {