| commit | 5689d6fec495037dc254a965e5184b64f4bdde85 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Wed Sep 05 08:44:35 2018 +0200 |
| committer | David Ostrovsky <david@ostrovsky.org> | Wed Sep 05 09:13:21 2018 +0200 |
| tree | 76dc659b7b3f77e57e4f6165f3a1015eb8f6013d | |
| parent | 21e6a0009194e8db9aead394050f4e89cf9a9b31 [diff] |
RestApiServlet: Skip capability check for administrators The migration to permission backend in I9458bd55fa wasn't equivalent: Old code: CapabilityUtils.checkRequiresCapability(globals.currentUser, null, rc.getClass()); New code: globals .permissionBackend .user(globals.currentUser) .checkAny(GlobalPermission.fromAnnotation(d.pluginName, d.view.getClass())); The skipping of capability check in the base version was erroneously omitted: if (ctl.canAdministrateServer()) { return; } This broke some plugins, most notably importer plugin. Plugin name is resolved to null (this is probably wrong too and indicates, that the capability check for plugin own capability is broken but it is a different bug). That why the check doesn't work, because import is a plugin capability and not gerrit core capability. The same wrong resolution of the plugin name to null is happening on stable-2.14 branch, but the only reason it works there, is because the capability check is omitted for administrators on stable-2.14 branch. Bug: Issue 8859 Change-Id: I61534cd9c5cd0da34782e671ae53c0b7fc2e4b65
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.