| commit | 560d3188f2accf18242392661bdaec896b92c8b2 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Mar 29 12:41:50 2017 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Mar 30 15:51:10 2017 +0200 |
| tree | cfef47e1f07ffd5bf85457e2a619568f823e208a | |
| parent | 384229ee9c9c7e4aae9e964b06575a1a0fa3fde0 [diff] |
Fix external ID cache The purpose of the external ID cache is to provide external IDs by account without need to reload all external IDs when one external ID is changed. To achieve this ExternalIdsUpdate informs the cache when an update to the external IDs is done so that the cache can apply the delta to the current value. The sequence in ExternalIdsUpdate is: 1. update external ID in NoteDb 2. inform the cache about the update The cache needs to know the old cache value in order to apply the delta. Instead of getting the old cache value it was wrongly reading the external IDs from the current revision of the NoteDb branch. Fix this by passing the old revision of the NoteDb branch to the cache and let the cache use this revision to get the old cache value. External IDs for the old revision are normally already loaded so that reloading the external IDs from NoteDb does not happen. Change-Id: Icb7277e726f77182939980d3365ffa92a93dcef4 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.