| commit | 55cbccba38995c46a1af08db5536d2fcb0a03bb1 | [log] [tgz] |
|---|---|---|
| author | Chris Poucet <poucet@google.com> | Tue Nov 16 03:17:06 2021 +0100 |
| committer | Chris Poucet <poucet@google.com> | Mon Nov 22 16:32:47 2021 +0100 |
| tree | 5667369a44fddb137d452344baa23b63f20c8639 | |
| parent | afaeb408b044bfa0fa2a6c169512a94a87bf3b94 [diff] |
Introduce the concept of Finalizable to tear down services. This will allow services and AppContext to be properly cleared when necessary. This is in the interest of getting rid of globals. In the parent change, it was discovered that some services don't clean up nicely hence this change. Additionally, as we will allow creating and removing of certain services (e.g. ChangeService and CommentsService) they will also need the ability to be cleaned up. In addition, clean up how we register services for tests and clean up after tests. Because we now subscribe more often as we are recreating Services for each test, subscriptions were leaking and there would be stack-overflow-errors in the subscribe logic. To address this, move away from using disconnected$ and instead rely on .unsubscribe() for subscriptions; Google-Bug-Id: b/206459178 Change-Id: I93ee6933ccc68728e1de174e1daac52cc4b83dc7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.