| commit | fbb18ecdc2dc0fc1156ec3583a69fb28d31569cb | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Dec 17 17:08:58 2015 +0100 |
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | Fri Dec 18 09:39:25 2015 +0900 |
| tree | c82396e7d594e42dd38c3c3ae0b9fcd3a3981b09 | |
| parent | dc71c4c60d5ab150da9313cea1f2c51be45a55ec [diff] |
Fix sending of inline comments on commit message for initial change Email notifications didn't include inline comments on the commit message for the initial change. For the initial change PatchListLoader creates an empty tree object for the a side, but PatchFile always tried to parse the a side as commit. If it's not a commit PatchFile can assume that this is the initial change and hence using an empty text for the a side is correct in this case. This error could be observed by running the LuceneQueryChangesTest in Eclipse, the console showed a lot of stack traces caused by IncorrectObjectTypeException in the CommentSender class. com.google.gerrit.server.mail.CommentSender : Cannot load /COMMIT_MSG from 318f37f6faeeebe601d9a91a7c98d08a6d3f6c3e in repo org.eclipse.jgit.errors.IncorrectObjectTypeException: Object 4b825dc642cb6eb9a060e54bf8d69288fbee4904 is not a commit. Full stack trace: http://paste.openstack.org/show/482173/ Bug: Issue 2251 Change-Id: I770d35153bd2b526240296a2e1a95ccc755fdfe1
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.