Support uploading dimension mismatch and side-by-side screenshot artifacts to ResultDB When a screenshot test fails due to a dimension mismatch (e.g., the height of a component changed), @web/test-runner-visual-regression fails before pixelmatch and outputs "Screenshot is not the same width and height as the baseline". Because the error message does not contain "Visual diff failed" and no diff image is generated, resultdb-reporter.mjs previously ignored these failures. Furthermore, on Linux CI bots, the screenshot directory is capitalized as "screenshots/Chromium/failed/", which requires case-insensitive handling. This change updates resultdb-reporter.mjs to extract artifact uploading into clean, modular helper functions that inspect screenshots/Chromium/failed/ (and lowercase chromium) when a visual diff failure or dimension mismatch occurs, match the failing test name to the actual screenshot file, and upload both the actual screenshot and baseline screenshot to ResultDB so they render side-by-side inline in Gerrit check summaries. Google-bug-id: b/510899910 Release-Notes: skip Change-Id: Ied3a153dce84676d45745011b12b20210243cf32
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.