Google Git
Sign in
gerrit / gerrit / 5381c5f1aeee254ede16bc0cb3e124d9f0d85abe
commit5381c5f1aeee254ede16bc0cb3e124d9f0d85abe[log] [tgz]
authorGal Paikin <paiking@google.com>Mon Sep 06 17:35:48 2021 +0200
committerGal Paikin <paiking@google.com>Thu Sep 23 11:49:56 2021 +0200
treed433c3aaec820228876e5c460323aa426efb5653
parent07e2b08c7f573b1ad36b53da93705aad63e260cb [diff]
Persist copying approvals to NoteDb

This change persists the copied votes to NoteDb and ensures they are
accessible by ChangeNotes. We do not use the copied votes in any way,
and this will be implemented in a follow-up change.

This is a step to stop computing copied votes on demand, but only
compute them once during new patch-set creation.

Advantages:
1. Better latency. Currently, to compute copied vote from ps1 to ps10,
we have to compute whether we can copy to ps1 -> ps2 -> ... -> ps10,
which is O(number of patch-sets), which can lead to bad latency. If we
persist the copied votes, we only have to look at the previous
patch-set.
2. Another argument of latency: this has to be computed every time
we retrieve the change, compared to once per patch-set upload.
3. Less error prone: we had a security issue that happened because of a
bug in the logic of copying across multiple patch-sets.

Disadvantages:
1. Either we perform a migration to persist past votes to NoteDb, OR, at
some point we stop computing the copied votes on demand, which means
that for old changes we will not have copied votes. However, this issue
already happens for old changes if the copy conditions for the project
change.
2. We used to be able to change the copy conditions on the project and
see the immediate effect on changes. That will no longer work: if a
vote is copied, it will stay copied (this can also be an advantage,
though).

Storage Layer:
We store the copied votes the same way that we store the other votes,
and we just add a "copied" flag.

Removed votes:
When removing votes we put a "0" vote on the current patch-set. Since
the keys for both votes and copied votes are the same, we don't need to
implement anything to allow removing votes. Copied votes on past
patch-sets will stay, but they will not be visible to the user as only
the latest patch-set matters.

Timestamps:
The timestamp of copied votes will be the commit timestamp (and not the
original vote's timestamp). This is fine especially since the timestamp
is not even user visible, and it somewhat makes sense that the timestamp
of the new copied vote is when the patch-set is created.

Google-bug-Id: b/195909329
Change-Id: Ia1ab9b3c5680362f6db31f71b29d7a922b98254d
21 files changed
tree: d433c3aaec820228876e5c460323aa426efb5653
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. twinkie.patch
  40. version.bzl
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.