commit 526e021526292c9ab87589e1dcd26fe042103ffe
author Shawn Pearce <sop@google.com> Tue Apr 23 16:40:45 2013 -0700
committer Shawn Pearce <sop@google.com> Tue Apr 23 16:40:45 2013 -0700
tree e94bb964e90bbf4f439e3b7b9835a98ac5313501
parent 98c89249c574d7a37c52825b9bb368cda35eca33

Allow InternalUser (aka plugins) to see any internal group

Permit plugins using the InternalUser as their current context user
to parse any group they know the name of. This will eventually allow
replication plugin to resolve authGroups from replication.config.

Bug: issue 1827
Change-Id: Ia9681b4e39a47ff1052225258e07f59435bc09cf

gerrit-server/src/main/java/com/google/gerrit/server/account/GroupControl.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupControl.java
index 5c9f012..2a8e7c9 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupControl.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupControl.java
@@ -21,6 +21,7 @@
 import com.google.gerrit.reviewdb.client.AccountGroup;
 import com.google.gerrit.server.CurrentUser;
 import com.google.gerrit.server.IdentifiedUser;
+import com.google.gerrit.server.InternalUser;
 import com.google.inject.Inject;
 import com.google.inject.Provider;
 import com.google.inject.Singleton;
@@ -127,6 +128,7 @@
   public boolean isVisible() {
     AccountGroup accountGroup = GroupDescriptions.toAccountGroup(group);
     return (accountGroup != null && accountGroup.isVisibleToAll())
+      || user instanceof InternalUser
       || user.getEffectiveGroups().contains(group.getGroupUUID())
       || isOwner();
   }