| commit | 51e45017af6a370ce4f6483a600b78e3e5b8b09f | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Jul 22 16:24:17 2016 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Fri Jul 22 16:33:03 2016 -0400 |
| tree | 0b6ae2a9ccf94bf9a06a9b216dc20355c4bf8ee6 | |
| parent | 9448ed4c8120e22e85632083cbd136324b69946b [diff] |
ChangeRebuilderImpl: Don't always drop updates when losing race Inside the AtomicUpdate where we check if the NoteDbChangeState has changed, an unequal state comparison does not necessarily mean that another thread has made the *same* update as this thread is trying to make. It might have been the same, which is ok to drop, but it might also be different. In the latter case, we were dropping the change without even attempting to execute the NoteDbUpdateManager, and returning to the caller as if the update was successful. The caller would then fail with a MissingObjectException because the object in question was never flushed. Distinguish these two cases with two different OrmRuntimeException. The latter case gets rethrown as an OrmException to indicate to the caller that they should build an in-memory RevWalk off of the staged results instead of trying to read from the repo. Change-Id: I0510db01d2ef48b5cfa06898392a6c9e4b2136bb
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.