| commit | 5198ad832ba7c869f9be686717084b3e6f43edce | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Fri Sep 24 16:35:21 2021 +0200 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Fri Sep 24 16:48:49 2021 +0200 |
| tree | 19cf9eabb1060a15ec46d753a8ab20c8bb0b4876 | |
| parent | 94166b0fa3626ec3d78e55ca3d8b3281ec9f475a [diff] |
SubmitRequirementsAdapter: Fix label status for custom submit rules
In SubmitRequirementsAdapter, we convert legacy submit records to a list
of submit requirement results. A submit record generated by a custom
submit rule (like the PrologRule) contains a combined status for the
record, along with a list of possible labels. Each label has an
individual status. For example, on gerrit-review our prolog rule
generates three different labels: Code-Review, Verified, Code-Style.
Each label has its status {OK, MAY, REJECT, NEED, IMPOSSIBLE}. The
submit record has a combined status which is passing if all the labels
are passing.
For custom submit rules, if the record has one or more labels we
generate one submit requirement result for each label. We used to set
the SR result status equals to the submit record status, which was wrong
since the SR result status should be set to the label status. This was
problematic if we convert a submit record containing a mix of pass/fail
labels; All the generated SR results had their status equals to the
record status which was fail, whereas passing labels should have
generated SR results with a pass status.
Bug: Google b/201054900
Change-Id: I9c3b5d5b768e129a0f1d8f96e824dadcf0dd7585
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.