Google Git
Sign in
gerrit / gerrit / 50fa6c9c0728b31a30bda1b0002bcec697a0f3ac
commit50fa6c9c0728b31a30bda1b0002bcec697a0f3ac[log] [tgz]
authorDavid Ostrovsky <david@ostrovsky.org>Sun Nov 12 11:08:55 2023 +0100
committerDavid Ostrovsky <david@ostrovsky.org>Tue Nov 14 05:54:31 2023 +0000
treed0518698eb69c4a82675e609c30dfb544b8191dd
parentf37d8dbe695f6ed1bef0cee5b64a93e38cfa3b77 [diff]
Stop merging lucene core and backward-codecs libraries

In I42fd1a130e merging of lucene core and backward-codecs jars with
Python script was introduced. In Ibe62917e20e the merging was ported
from Python script to java_binary() rule.

Underlying Bazel implementation is using singlejar utility to merge java
binaries. This utility has currently limitation: [1] for Multi-Release
JARs Java feature: [2]  "Multi-Release: true" is lost in the resulting
manifest file.

While it would be trivial to restore the MR-JAR bit in the resulting
merged artifact, by adding the bit manually using deploy_manifest_lines
attribute of java_binary() rule, we remove the merging of those JARs.

We don't understand why the merging was needed to start with.

In I42fd1a130e the commit message is describing how the JARs are merged
but not why they are merged.

Also, see the discussion in this upstream issue for more details: [3].

[1] https://github.com/bazelbuild/bazel/issues/10507
[2] https://openjdk.org/jeps/238
[3] https://github.com/apache/lucene/issues/12307

Bug: Issue 310399475
Release-Notes: skip
Change-Id: I4b0df5fa38c23de54311375103966b6f1c8eddb7
8 files changed
tree: d0518698eb69c4a82675e609c30dfb544b8191dd
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. web-dev-server.config.mjs
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.