commit 4e73c9330292523e8a3542d9aa9f653a0b36af3b
author Shawn Pearce <sop@google.com> Tue Jan 07 15:55:33 2014 -0800
committer Shawn Pearce <sop@google.com> Wed Jan 08 00:16:12 2014 +0000
tree 41a8c8426b2830658d8933d89133618ef5e381c5
parent be846395668db1da2d06b039a3a6cf4e0295ede7

SideBySide2: Reclaim more browser keys from vim

Ctrl-R is reload page. This is useful when developing a web UI.
In vim mode it means redo a change which was undone, which is
useless on a read-only buffer. Delete Ctrl-R and allow the browser
to handle it.

Also delete Ctrl-P (previous line, useless) and Ctrl-S.

Delete Ctrl-{0..9} so Chrome can switch between tabs.

Change-Id: I22da04bcf7d9754787214c1b7321e5ddfaf8520b

gerrit-gwtui/src/main/java/net/codemirror/lib/Loader.java

diff --git a/gerrit-gwtui/src/main/java/net/codemirror/lib/Loader.java b/gerrit-gwtui/src/main/java/net/codemirror/lib/Loader.java
index e4ac7b1..9e5d30a 100644
--- a/gerrit-gwtui/src/main/java/net/codemirror/lib/Loader.java
+++ b/gerrit-gwtui/src/main/java/net/codemirror/lib/Loader.java
@@ -91,10 +91,15 @@
     // TODO: Better custom keybindings, remove temporary navigation hacks.
     KeyMap km = CodeMirror.cloneKeyMap("vim");
     for (String s : new String[] {
-        "A", "C", "I", "O", "R", "U", "Ctrl-C", "Ctrl-O"}) {
+        "A", "C", "I", "O", "R", "U",
+        "Ctrl-C", "Ctrl-O", "Ctrl-P", "Ctrl-S"}) {
       km.remove(s);
     }
+    for (int i = 0; i <= 9; i++) {
+      km.remove("Ctrl-" + i);
+    }
     CodeMirror.addKeyMap("vim_ro", km);
+
     CodeMirror.mapVimKey("j", "gj");
     CodeMirror.mapVimKey("k", "gk");
     CodeMirror.mapVimKey("Down", "gj");