Revisions: Clarify lookup logic
find() now always returns revisions from the same change. It is no
longer necessary to look at Change.Id in this condition. In fact the
prior commit fixed a hidden bug this loop couldn't identify caused by
the RevisionResource having the wrong PatchSet associated to the
current Change. Pushing the filter logic down inside of match helps
to eliminate this bug.
The legacy PatchSet.Id syntax is verbose and easier to read when moved
into its own method.
The database scans on patchSets by revision id will need to change
as the database moves to notedb. Push these into their own helpers
that more easily clarify the two conditions being tested.
Inline the singleton toResources method, it's small and its name
was misleading converting a single PatchSet into a "resources".
The plural could mislead readers.
Change-Id: I1bb71a513b9e75aec10d6184d75105dd1a03c167
1 file changed
