commit 4d87db8d5e425c637c4fac1e347dbe8a31f7f58e
author Paladox none <thomasmulhall410@yahoo.com> Wed Nov 10 02:37:33 2021 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Thu Nov 11 21:27:39 2021 +0000
tree 96cbb76df66d17dc96f6133b1537006bfaf7ccd2
parent f2b65fa90ca17ca6b3a113292fb69b4e2fd67107

gr-repo: Use gr-textarea

This fixes an issue where the background for the description
box was grey. It should be white if you can edit and darkened
if you cannot.

Change-Id: I185b49a8c770b27e1c6fea81be16602527b9a7c1

polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts

diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts
index 47a4362..bf0b393 100644
--- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts
+++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts
@@ -14,13 +14,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea';
 import '@polymer/iron-input/iron-input';
 import '../../plugins/gr-endpoint-decorator/gr-endpoint-decorator';
 import '../../plugins/gr-endpoint-param/gr-endpoint-param';
 import '../../shared/gr-button/gr-button';
 import '../../shared/gr-download-commands/gr-download-commands';
 import '../../shared/gr-select/gr-select';
+import '../../shared/gr-textarea/gr-textarea';
 import '../gr-repo-plugin-config/gr-repo-plugin-config';
 import {GerritNav} from '../../core/gr-navigation/gr-navigation';
 import {
@@ -245,15 +245,17 @@
     return html`
       <h3 id="Description" class="heading-3">Description</h3>
       <fieldset>
-        <iron-autogrow-textarea
+        <gr-textarea
           id="descriptionInput"
           class="description"
           autocomplete="on"
           placeholder="&lt;Insert repo description here&gt;"
-          .bindValue=${this.repoConfig?.description}
+          rows="4"
+          monospace
           ?disabled=${this.readOnly}
-          @bind-value-changed=${this.handleDescriptionBindValueChanged}
-        ></iron-autogrow-textarea>
+          .text=${this.repoConfig?.description}
+          @text-changed=${this.handleDescriptionTextChanged}
+        >
       </fieldset>
     `;
   }
@@ -1114,7 +1116,7 @@
     this.selectedScheme = e.detail.value;
   }
 
-  private handleDescriptionBindValueChanged(e: BindValueChangeEvent) {
+  private handleDescriptionTextChanged(e: CustomEvent) {
     if (!this.repoConfig || this.loading) return;
     this.repoConfig = {
       ...this.repoConfig,

polygerrit-ui/app/elements/admin/gr-repo/gr-repo_test.ts

diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo_test.ts b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo_test.ts
index 86dccff..82338d3 100644
--- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo_test.ts
+++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo_test.ts
@@ -54,7 +54,7 @@
 import {PageErrorEvent} from '../../../types/events.js';
 import {GrButton} from '../../shared/gr-button/gr-button';
 import {GrSelect} from '../../shared/gr-select/gr-select';
-import {IronAutogrowTextareaElement} from '@polymer/iron-autogrow-textarea/iron-autogrow-textarea';
+import {GrTextarea} from '../../shared/gr-textarea/gr-textarea';
 import {IronInputElement} from '@polymer/iron-input/iron-input';
 
 const basicFixture = fixtureFromElement('gr-repo');
@@ -494,10 +494,8 @@
           '#Title'
         ).classList.contains('edited')
       );
-      queryAndAssert<IronAutogrowTextareaElement>(
-        element,
-        '#descriptionInput'
-      ).bindValue = configInputObj.description;
+      queryAndAssert<GrTextarea>(element, '#descriptionInput').text =
+        configInputObj.description;
       queryAndAssert<GrSelect>(element, '#stateSelect').bindValue =
         configInputObj.state;
       queryAndAssert<GrSelect>(element, '#submitTypeSelect').bindValue =