commit 4c8ffca553ae465ac554d068a97cd36620373e95
author Dhruv Srivastava <dhruvsri@google.com> Mon Sep 05 09:37:07 2022 +0200
committer Dhruv Srivastava <dhruvsri@google.com> Mon Sep 05 09:13:52 2022 +0000
tree f8458766c6fd26027ae6220af3b2900c8d4da657
parent 46fa804dc79d330db518e10549f844a4a65aa588

Move fetching detailed accounts from firstUpdated to updated

It's unclear why but upon closing and reopening the reply dialog
the render() method is called twice which means the update caused
by firstUpdated to account is lost.
The fetching of the account is cached in the accounts model hence
we are not making unnecessary requests.

Release-Notes: skip
Google-bug-id: b/236921879
Change-Id: I9ba675f7ae5fe279aa92a4b4ec4ccfcf2ef1d47a

polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts

diff --git a/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts b/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts
index 3958c67..2985e62 100644
--- a/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts
+++ b/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts
@@ -188,7 +188,7 @@
     ];
   }
 
-  override async firstUpdated() {
+  override async updated() {
     assertIsDefined(this.account, 'account');
     const account = await this.accountsModel.fillDetails(this.account);
     if (account) this.account = account;