commit 4c146e5ef49a24df9771bdc3755a7d80cdf545b4
author Dave Borowitz <dborowitz@google.com> Fri Dec 13 14:28:48 2013 -0800
committer Dave Borowitz <dborowitz@google.com> Fri Dec 13 22:38:52 2013 +0000
tree 1eef2f3089b621f930d4aea1be03c0d8b710921b
parent baf96c47f797cf7d4ba30ecf02a5d37212c13ba3

Format +1 vote on label as Label+1

This matches the old behavior used in emails.

Continue to parse +1 for both Label+1 and bare Label.

Change-Id: Ic1cfc9ab15a515b12491975586fda20da41b0f2f

gerrit-server/src/main/java/com/google/gerrit/server/util/LabelVote.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/util/LabelVote.java b/gerrit-server/src/main/java/com/google/gerrit/server/util/LabelVote.java
index b8d942d..9032eca 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/util/LabelVote.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/util/LabelVote.java
@@ -75,8 +75,6 @@
   public String format() {
     if (value == (short) 0) {
       return '-' + name;
-    } else if (value == (short) 1) {
-      return name;
     } else if (value < 0) {
       return name + value;
     } else {

gerrit-server/src/test/java/com/google/gerrit/server/util/LabelVoteTest.java

diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/util/LabelVoteTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/util/LabelVoteTest.java
index d7ae61a..0ed0ba8 100644
--- a/gerrit-server/src/test/java/com/google/gerrit/server/util/LabelVoteTest.java
+++ b/gerrit-server/src/test/java/com/google/gerrit/server/util/LabelVoteTest.java
@@ -34,6 +34,9 @@
     l = LabelVote.parse("Code-Review");
     assertEquals("Code-Review", l.getLabel());
     assertEquals((short) 1, l.getValue());
+    l = LabelVote.parse("Code-Review+1");
+    assertEquals("Code-Review", l.getLabel());
+    assertEquals((short) 1, l.getValue());
     l = LabelVote.parse("Code-Review+2");
     assertEquals("Code-Review", l.getLabel());
     assertEquals((short) 2, l.getValue());
@@ -44,7 +47,7 @@
     assertEquals("Code-Review-2", LabelVote.parse("Code-Review-2").format());
     assertEquals("Code-Review-1", LabelVote.parse("Code-Review-1").format());
     assertEquals("-Code-Review", LabelVote.parse("-Code-Review").format());
-    assertEquals("Code-Review", LabelVote.parse("Code-Review").format());
+    assertEquals("Code-Review+1", LabelVote.parse("Code-Review+1").format());
     assertEquals("Code-Review+2", LabelVote.parse("Code-Review+2").format());
   }