Google Git
Sign in
gerrit / gerrit / 4b2b9b4036ec1040d87edc0e2b4ac230d114615d
commit4b2b9b4036ec1040d87edc0e2b4ac230d114615d[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Fri Nov 15 11:08:17 2019 +0100
committerDavid Pursehouse <dpursehouse@collab.net>Fri Nov 15 11:35:40 2019 -0800
tree8f696714065a4f954d8ffd14aaeeb5fca5b06ad5
parentf986c7211ac254c515292289b7529297df1b9fed [diff]
DeleteBranch/DeleteBranches: Disallow deletion of HEAD to prevent NPE

Attempting to delete HEAD fails with a NullPointerException [1]. This is
because 'HEAD' gets prefixed with 'refs/heads/' and then the ref is not
found.

We may consider to support deleting HEAD, but that's outside the scope
of this change. E.g. deleting HEAD may rather be separate REST endpoint
that lives next to SetHead since setting HEAD requires a different
permission than deleting a ref.

[1]
java.lang.NullPointerException
        at com.google.gerrit.server.restapi.project.DeleteRef.deleteSingleRef(DeleteRef.java:122)
        at com.google.gerrit.server.restapi.project.DeleteBranch.apply(DeleteBranch.java:59)
        at com.google.gerrit.server.restapi.project.DeleteBranch.apply(DeleteBranch.java:34)
        at com.google.gerrit.httpd.restapi.RestApiServlet.lambda$invokeRestModifyViewWithRetry$4(RestApiServlet.java:740)
        at com.github.rholder.retry.AttemptTimeLimiters$NoAttemptTimeLimit.call(AttemptTimeLimiters.java:78)
        at com.github.rholder.retry.Retryer.call(Retryer.java:160)
        at com.google.gerrit.server.update.RetryHelper.executeWithTimeoutCount(RetryHelper.java:417)
        at com.google.gerrit.server.update.RetryHelper.executeWithAttemptAndTimeoutCount(RetryHelper.java:368)
        at com.google.gerrit.server.update.RetryHelper.execute(RetryHelper.java:271)
        at com.google.gerrit.httpd.restapi.RestApiServlet.invokeRestEndpointWithRetry(RestApiServlet.java:820)
        at com.google.gerrit.httpd.restapi.RestApiServlet.invokeRestModifyViewWithRetry(RestApiServlet.java:735)
        at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:511)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
        ...

Change-Id: I44c23f4553f05300b7c79bf257b417ec0b496b09
Signed-off-by: Edwin Kempin <ekempin@google.com>
(cherry picked from commit 40e1ab1bf084f0b7da66e84b26a84cc4604cbeeb)
4 files changed
tree: 8f696714065a4f954d8ffd14aaeeb5fca5b06ad5
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. README.md
  36. SUBMITTING_PATCHES
  37. version.bzl
  38. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.