Avoid creating HTTP Sessions for Git-over-HTTP

The Change-Id: Iffcd0fbd7 has involuntarily triggered the
creation of a new HTTP Session for every invocation a Git-over-HTTP
request.

All came from the mistake of tracing the HTTP session instead
of the Gerrit session in the audit record.
The HTTP Servlet API specs say that any attempt to access
the current session of an incoming request would result
in the creation of a brand-new session.

The session involuntarily created also had an expiry time
equal to zero, which prevented the session housekeeper
to reclaim them later on, even though they were unused.

The consequence of creating an empty session for every
Git-over-HTTP request isn't immediately tangible, because
the session is empty and doesn't occupy a significant
amount of memory. However, longer-term, the in-memory
hashtable that records all the sessions, each one using
750 bytes on average, will be causing the overload
of the JVM heap and the crash of the process because of
lack of available memory.

Use the correct Gerrit session-id, retrieving
from the Provider<WebSession> the proper session, if active
and logged in, and make sure in tests that no HTTP sessions
are created as a result of a Git-over-http request.

Bug: Issue 13858
Change-Id: I8c086fed54b196c3f46fa88ac78c127784524d30
5 files changed
tree: f3e655ca41ee8c32a7315611556930c33f72e2e5
  1. .bazelignore
  2. .bazelproject
  3. .bazelrc
  4. .bazelversion
  5. .editorconfig
  6. .git-blame-ignore-revs
  7. .gitignore
  8. .gitmodules
  9. .gitreview
  10. .mailmap
  11. .pydevproject
  12. .settings/
  13. BUILD
  14. COPYING
  15. Documentation/
  16. INSTALL
  17. Jenkinsfile
  18. README.md
  19. ReleaseNotes/
  20. SUBMITTING_PATCHES
  21. WORKSPACE
  22. contrib/
  23. gerrit-acceptance-framework/
  24. gerrit-acceptance-tests/
  25. gerrit-cache-h2/
  26. gerrit-cache-mem/
  27. gerrit-common/
  28. gerrit-elasticsearch/
  29. gerrit-extension-api/
  30. gerrit-gpg/
  31. gerrit-gwtdebug/
  32. gerrit-gwtexpui/
  33. gerrit-gwtui-common/
  34. gerrit-gwtui/
  35. gerrit-httpd/
  36. gerrit-index/
  37. gerrit-launcher/
  38. gerrit-lucene/
  39. gerrit-main/
  40. gerrit-oauth/
  41. gerrit-openid/
  42. gerrit-patch-commonsnet/
  43. gerrit-patch-jgit/
  44. gerrit-pgm/
  45. gerrit-plugin-api/
  46. gerrit-plugin-gwtui/
  47. gerrit-prettify/
  48. gerrit-reviewdb/
  49. gerrit-server/
  50. gerrit-sshd/
  51. gerrit-test-util/
  52. gerrit-util-cli/
  53. gerrit-util-http/
  54. gerrit-util-ssl/
  55. gerrit-war/
  56. lib/
  57. plugins/
  58. polygerrit-ui/
  59. tools/
  60. version.bzl
  61. website/
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.