29de43630afa75aaf601cb4e90acd752774fa87e - gerrit

commit	29de43630afa75aaf601cb4e90acd752774fa87e	[log] [tgz]
author	Shawn O. Pearce <sop@google.com>	Wed Mar 03 17:51:26 2010 -0800
committer	Shawn O. Pearce <sop@google.com>	Mon Mar 08 08:09:08 2010 -0800
tree	48415a71888f7f10784056c101a87d5bab682934
parent	afd1514e5eb1f0853505fe51f6bdf79b389a9dec [diff]

Permit cache.diff.intraline to disable MyersDiff

I can't fix the infinite loop in JGit's MyersDiff implementation in
a reasonable time frame.  But its a data dependent bug that triggers
only rarely, most of the time the intraline difference feature works
"well enough" to be useful, and a number of sites are running with
it live.

Lets make it available by default, but give the server administrator
a way to easily opt-out of the feature if they run into the same
sort of bug that issue 487 identifies.

Bug: issue 487
Change-Id: I257be95ac93c0775d24fcd36a315f293503febb7
Signed-off-by: Shawn O. Pearce <sop@google.com>

Documentation/config-gerrit.txt[diff]
gerrit-common/src/main/java/com/google/gerrit/common/data/PatchScript.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java[diff]
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptFactory.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListKey.java[diff]

10 files changed