Fix label migration for branch patterns in submit requirements Current situation: The label migration API converts labels with function = MaxWithBlock into submit requirements. However, branch patterns are currently migrated by embedding the original branch value directly into the applicableIf expression. For example: [label "rest-authz"] branch = refs/heads/* function = MaxWithBlock was migrated to: [submit-requirement "rest-authz"] applicableIf = branch:\\\"refs/heads/*\\\" Motivation: This is not a valid Gerrit query expression. While refs/heads/* is a valid label branch pattern, the branch: operator in submit requirement expressions expects either an exact branch name or a regular expression. Fix: This change converts branch patterns during migration as follows: refs/heads/master -> branch:"refs/heads/master" refs/heads/* -> branch:^refs/heads/.* refs/* -> branch:^refs/.* ^refs/heads/.* -> branch:^refs/heads/.* refs/heads/hi\"ch -> branch:"refs/heads/hi\"ch" refs/heads/hi#ch -> branch:"refs/heads/hi#ch" As a result, the generated applicableIf expressions are valid and preserve the semantics of the original label branch restrictions. NOTE: After migration, When Jgit persists the data into config, it is persisted with escaping characters. E.g. [label "rest-authz-hash"] branch = "refs/heads/hi#ch" -> persisted after migration to [submit-requirement "rest-authz-hash"] applicableIf = branch:\"refs/heads/hi\\\"ch\" But during runtime, it is interpreted as `branch:"refs/heads/hi\"ch"` Change-Id: I80aaa87019a9e8412be5e26949cd150c9ffe6515 Release-Notes: Fix label migration for branch patterns in submit requirements
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.