Allow expanding check results with no summary
It's not clear why summary was required for expandability before, but
based on the bug-report, there are cases where the check has no summary
but has a message that can be expanded.
Google-Bug-Id: b/318777876
Release-Notes: skip
Change-Id: I48eeaab09e60c64bda46317b4f632d83b854bea9
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
index 6f4a415..bc0e015 100644
--- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts
+++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
@@ -463,7 +463,7 @@
}
renderSummary(text?: string) {
- if (!text) return;
+ text = text ?? '';
return html`
<!-- The is for being able to shrink a tiny amount without
the text itself getting shrunk with an ellipsis. -->
diff --git a/polygerrit-ui/app/models/checks/checks-util.ts b/polygerrit-ui/app/models/checks/checks-util.ts
index 6286a80..bb5030c 100644
--- a/polygerrit-ui/app/models/checks/checks-util.ts
+++ b/polygerrit-ui/app/models/checks/checks-util.ts
@@ -520,7 +520,6 @@
}
export function computeIsExpandable(result?: CheckResultApi) {
- if (!result?.summary) return false;
const hasMessage = !!result?.message;
const hasMultipleLinks = (result?.links ?? []).length > 1;
const hasPointers = (result?.codePointers ?? []).length > 0;
diff --git a/polygerrit-ui/app/models/checks/checks-util_test.ts b/polygerrit-ui/app/models/checks/checks-util_test.ts
index 83b4cd6..ead7dd01 100644
--- a/polygerrit-ui/app/models/checks/checks-util_test.ts
+++ b/polygerrit-ui/app/models/checks/checks-util_test.ts
@@ -121,7 +121,7 @@
});
test('no summary', () => {
- assert.isFalse(
+ assert.isTrue(
computeIsExpandable({
...createCheckResult(),
message: 'asdf',
