commit 5f37a9fca05cf06528da885437f70557d5eea2b5
author Pascal Krause <pascal.krause@sap.com> Mon Feb 15 17:12:00 2016 +0100
committer David Pursehouse <david.pursehouse@sonymobile.com> Fri Feb 19 00:48:46 2016 +0000
tree 0c2fb60aa79c0c2ebd2648bc67861e86cb4e32c0
parent 9e329325de3608b1103c88e463091e3f59c31e86

Fix keyboard shortcuts for non-US keyboards

The forward/backward navigation keys "[" and "]" worked only on those
keyboards where these characters could be typed without using any
modifier key (like CTRL, ALT, etc..). For example, on German keyboard
the "[" is entered as ALTGR+8. Webkit browsers translate the ALTGR
modifier into CTRL+ALT (This seems not to be true in Linux. Because
of this fact, this change doesn't have any effect on Linux). Further,
our code in gwtexpui checks for CTRL and ALT keys and modifies the
entered key accordingly. Therefore, the "[" typed on German keyboard
gets modified to some other key.

This change removes the special processing of CTRL and ALT key
modifiers and makes the "[", "]" and likely a few other keys work
on German (and likely other) keyboard.

A further issue with the "[" and "]" keys is when the focus is inside
codemirror. CM detects the keys correctly, but when CM lookup
for a key handler in the keymap it wrap the key into two "'". Because
of this CM looks for a key with the value "'['" or "']'". But in
SideBySide.java the keys were defined as "[" and "]". So CM couldn't
find the defined key handler and used other CM native handlers for
these keys.

Bug: issue 1207
Change-Id: I8e7d552b3927047b31ced373eafac3436a70b277