| commit | 47b268cc12787be9fedfc8484747265749d02a14 | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Fri Apr 05 15:58:03 2024 +0200 |
| committer | Kamil Musin <kamilm@google.com> | Mon Apr 08 11:56:05 2024 +0200 |
| tree | 325a8982df37ebe3df813f32cb889bc0b82d407e | |
| parent | c5e8e89e8dfb5350f034d99518f2f52fc21e1351 [diff] |
Do not request revision information from reply dialog. For PostReview the web UI currently always requests revision information to learn about new revisions that have been uploaded concurrently (uploaded since the change screen was last reloaded). If no revision has been uploaded concurrently the revision data is computed by backend unnecessarily, which is expensive and increases the latency of the response. (the revision data never changes as result of a PostReview request). In I30f69f638 Backend was updated to return the current revision number. With this change we update the logic to only request the revision data only if needed. Based on the last known patchset in the PostReview response frontend will trigger the reload if extra information is required. Since the revision information is no longer requested and therefore not present in the response to PostReview, we carry-over existing revision information from the currently known ChangeInfo. If the current_revision_number is outdated, we will then schedule the complete reload of the ChangeInfo. However this reload is explicitly not included in the SendReply timing information, which completes as soon as PostReview requests finishes and UI updates. Within the reply dialog there was another place where an expensive fetch of all revisions was previously happening. Opening of reply dialog would request change detail to see if the newer patchset is available. We update the fetchChangeUpdates to use cheaper getChange() method instead, since similar to "send" only the number is needed and it's now available, without extra options. Google-Bug-Id: b/330155872 Release-Notes: skip Change-Id: I432ec3e4cd02437a58d47230be8acfa82c63d295
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.