Google Git
Sign in
gerrit / gerrit / a24775b555347e6130b4dc8d08c4fbc4ffa81d15
commita24775b555347e6130b4dc8d08c4fbc4ffa81d15[log] [tgz]
authorMilutin Kristofic <milutin@google.com>Wed Nov 25 14:33:24 2020 +0100
committerPaladox none <thomasmulhall410@yahoo.com>Thu Apr 08 15:24:48 2021 +0000
tree19e74c70baae73c34ecf26b780ede16ccf268591
parentc4314da61fbe6eccc296e4f59cead5f7d7dd3b7a [diff]
A11y - fix and improve label when navigating dashboard

Recent regression: When using j/k on dashboard, screen reader doesn't
announce content of dashboard row. This was caused by change:
Change-Id: Ica3784499ac0ebb1a3986bff1f21028ab5f8b032

Before that change:
cursor.next updates index, which propages to selectedIndex in change
list and changes tabIndex of items, so next item has tabindex = 0 and
then cursor.next calls focus on next item.

Without two-way binding of index and selectedIndex, selectedIndex is
called after focus is called and tabIndex is still -1, so focus fails.

Change-Id: Id01302aea38c783687443401290995bdd0764126
(cherry picked from commit 28b3c2c8e3cfdf9e8125016e672c8e8ca32f0b40)
2 files changed
tree: 19e74c70baae73c34ecf26b780ede16ccf268591
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.