| commit | 46986e08b868e60291a4868e4566393329fc7e26 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Sep 28 12:53:44 2018 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Sep 28 13:10:31 2018 +0200 |
| tree | 4b21b4c2ea1dda462d212aaccedc7c01f256872f | |
| parent | b9f605307d2c5833fa13ec59e058b8f8aa93097c [diff] |
Remove unneeded submodule submit logs that spam the error log For projects that use submodules extensively we create lots of unneeded logs during submit (if log level is DEBUG or if the request is traced). GitModule#subscribedTo(Branch.NameKey) was logging 1. the branch name for which submodule subscriptions are checked 2. the found subscriptions SubmoduleOp#superProjectSubscriptionsForSubmoduleBranch(Branch.NameKey) is the only caller of GitModule#subscribedTo(Branch.NameKey) and it already logs the branch name that is passed into GitModule#subscribedTo(Branch.NameKey) and the results that it gets back so that logs in GitModule#subscribedTo(Branch.NameKey) are unneeded and can be removed without losing information. SubmoduleOp#superProjectSubscriptionsForSubmoduleBranch(Branch.NameKey) logs all results from GitModule#subscribedTo(Branch.NameKey) with a single log entry. This is much less noisy then logging each result separately as it was done by GitModule#subscribedTo(Branch.NameKey). In addition make GitModule#subscribedTo(Branch.NameKey) package-private since it's not used outside of the package. Also make the subscriptions field in GitModules private since it's only used within this class. Change-Id: I28cabdca650368348bb44c04699592a9ede8478e Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.