commit | 59957d569a5e57d3cde30c23b4d0a0558923e4e1 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed Jan 11 15:23:23 2023 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Wed Jan 11 15:36:46 2023 +0100 |
tree | cd36c9ae9ff9714b6b1a0281c43cd91ee39b3dcb | |
parent | 2cc3b5b8d0e4a74bfe361cf725dc884807fddd8e [diff] |
CreateChange: Fix matching project check for projects with trailing slash For the CreateChange REST endpoint on the projects collection the project is specified as part of the URL (POST /projects/<project>/create.change). Specifying the project name in the ChangeInput is not required, but if the project is provided there it must match the project in the URL. The check for this incorrectly rejected projects with trailing slash: * ProjectsCollection sanatizes the project name that is retrieved from the URL (e.g. it drops any trailing slash). * Now in CreateChange the sanatized project name that was retrieved from the URL mismatched the non-sanitized project name in ProjectInput if the project was specified with a trailing slash in both places. * The resulting error message is confusing for users as it claims there was a mismatch, althought the user specified the same project name (with trailing slash) at both places. Fix this by sanitizing the project name from ProjectInput before comparing it against the sanatized project name that was retrieved from the URL. Bug: Google b/183100838 Release-Notes: skip Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ib9c2258a72f75497f6375dc48fa1eb5781d719fa
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.