commit | 45d5d1dd8e3ac7655ed86273812f9b284b183699 | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Fri Dec 23 15:44:15 2022 +0100 |
committer | Youssef Elghareeb <ghareeb@google.com> | Fri Dec 23 15:44:15 2022 +0100 |
tree | 6226736c48c9680763eefdc1452e10461aa8eb94 | |
parent | bd0767739bedfdb2baf3eef6207be7bc63f39504 [diff] |
Remove unnecessary checks for notify.shouldNotify() Different callers are checking notify.shouldNotify() but this check is redundant since all callers do the same check again down the stack while sending the email (see [1]). Removing these checks to simplify the implementation. Note that the distance in code between the removed checks and the check in OutgoingEmail is not big and we don't do expensive computations in between. [1] https://gerrit.googlesource.com/gerrit/+/8239d5c835da30bda499a2e2c833ebe9d1270752/java/com/google/gerrit/server/mail/send/OutgoingEmail.java#129 Release-Notes: skip Change-Id: I2059d0663e98444bfa3be8b9c6917b5b9bb43cac
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.